Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --keep_going to make Bazel support more robust #288

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Silic0nS0ldier
Copy link

Resolves #287

With the changes in this PR, the language server works much better in the Bazel repository (provided bazel build //src:bazel-dev has been run, otherwise the external dependencies aren't in the expected places).

Also included in this PR;

  • Noted that temporary files for Bazel command output are not cleaned up after use.
  • Pinned Bazel examples (used in tests) to version 4.2.4, which appears to be the version expected. Without this tests will fail due to bazelisk (from Github actions runners) will pull in the latest stable release (7.2.x at time of writing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Bazel integration more fault tolerant with --keep_going
1 participant