-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why exactly is it deprecated? #44
Comments
May be what is being referred to is this sort of thing: microsoft/vscode#86415 FWIW, there is another effort for doing syntax highlighting via tree-sitter for VSCode here: https://github.com/EvgeniyPeshkov/syntax-highlighter |
|
The last commit was in 2021? |
I'd imagine writing whole a language server is an order of magnitude more difficult than simply adding a tree sitter grammar file. So I also don't understand the deprecation. Those are just two different things. |
Whoops. I was thinking of the discussion in jeff-hykin/experimental-tree-sitter. |
Yes, I did upgrade {Syntax Highlighter} locally. Unfortunately, I had to remove Ruby and D languages. Over the weekends I managed to make it run in VS Code again, added qmljs syntax/parser, and it even somehow worked. However, speaking from my brief experience, it made things worse for Python sources. Also that very custom format of grammars json is quite limiting compared to native tree-sitter query language, and reparsing the whole document on every change without accounting for edit deltas doesn't sound very efficient. I haven't got around to experiment with this repo yet, but from what I gather, colors.ts manually walks up and down the tree in a less declarative way than {Syntax Highlighter} does. Not sure what would be the best path from here… |
Hi, I'm new in VSCode extension development. I can't get how the new VSCode feature replaced this addon.
As I understand the code highlighting is not in the scope of LSP specification. The tree-sitter does a good job on it. Is there some extension in LSP - VCCode communication that allows the server to submit coloring properties?
The text was updated successfully, but these errors were encountered: