-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TDP/Power limit #24
Comments
I've thought a bit about this- mostly can't think of a nice way to expose options for user. I think it would be nice to allow different settings on battery and AC (like temp limit), so we 8 values in total to set. Maybe if we allow two values per option we can have --tdp-short-bat "15 30" --tdp-long-ac "20 40" etc. Any better suggestion? PR welcome if you want to attempt this yourself :) |
For the option (and could be applied for the temperature too) I have a suggestion, while not solving all issues, remove at least one option. Rather than having one option for all, one option for AC and one option for battery why not just applying the temperature for ac and bat automatically. If the user also use a bat, the value is overridden when it is on battery. Then for instance for temperature. Case 1: Uses of -t only
Case 2: Use of -t and -t-bat
Case 3: Use of -t-bat only
For PR, I may take a look but I am far competent for that. |
@Oliph That's a good suggestion, thanks! I think I will have some time this weekend to look at this |
Closed via #93 |
Hi,
Are you planning to add options to change theTDP?
This wrapper is doing it: https://github.com/kitsunyan/intel-undervolt but I woul rather stick to yours.
Thank you anyway
The text was updated successfully, but these errors were encountered: