minor updates

georgia-tech-db · Sep 29, 2023 · 29259c5 · 29259c5
1 parent 27a3392
commit 29259c5
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 12 deletions.
diff --git a/evadb/catalog/catalog_manager.py b/evadb/catalog/catalog_manager.py
@@ -192,7 +192,7 @@ def check_native_table_exists(self, table_name: str, database_name: str):
             resp = handler.get_tables()
 
             if resp.error is not None:
-                return False
+                raise Exception(resp.error)
 
             # Check table existence.
             table_df = resp.data

diff --git a/evadb/storage/native_storage_engine.py b/evadb/storage/native_storage_engine.py
@@ -170,7 +170,7 @@ def read(
                 # we prefer the generator/iterator when available
                 result = []
                 if handler_response.data_generator:
-                    result = handler_response.data_generator()
+                    result = [next(handler_response.data_generator)]
                 elif handler_response.data:
                     result = handler_response.data
 

diff --git a/evadb/third_party/databases/github/github_handler.py b/evadb/third_party/databases/github/github_handler.py
@@ -38,18 +38,18 @@ def __init__(self, name: str, **kwargs):
 
     @property
     def supported_table(self):
+
+        def _stargazer_generator():
+            for stargazer in self.connection.get_repo("{}/{}".format(self.owner, self.repo)).get_stargazers():
+                yield {
+                    property_name: getattr(stargazer, property_name)
+                    for property_name, _ in STARGAZERS_COLUMNS
+                }
+
         mapping = {
             "stargazers": {
                 "columns": STARGAZERS_COLUMNS,
-                "generator": lambda: [
-                    {
-                        property_name: getattr(stargazer, property_name)
-                        for property_name, _ in STARGAZERS_COLUMNS
-                    }
-                    for stargazer in self.connection.get_repo(
-                        "{}/{}".format(self.owner, self.repo)
-                    ).get_stargazers()[:1]
-                ],
+                "generator": _stargazer_generator(),
             },
         }
         return mapping

diff --git a/test/third_party_tests/test_github_datasource.py b/test/third_party_tests/test_github_datasource.py
@@ -35,7 +35,6 @@ def test_should_run_select_query_in_github(self):
         params = {
             "owner": "georgia-tech-db",
             "repo": "evadb",
-            "github_token": "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",
         }
         query = f"""CREATE DATABASE github_data
                     WITH ENGINE = "github",