fix: if create table fails, we were not cleaning the entry in catalog (…

…#1208)

#1205

evadb/executor/create_executor.py

@@ -12,6 +12,8 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+import contextlib
+
 from evadb.database import EvaDBDatabase
 from evadb.executor.abstract_executor import AbstractExecutor
 from evadb.executor.executor_utils import (
@@ -20,6 +22,7 @@
 )
 from evadb.plan_nodes.create_plan import CreatePlan
 from evadb.storage.storage_engine import StorageEngine
+from evadb.utils.errors import CatalogError
 from evadb.utils.logging_manager import logger
 
 
@@ -70,4 +73,7 @@ def exec(self, *args, **kwargs):
                 # rollback if the create call fails
                 if create_table_done:
                     storage_engine.drop(catalog_entry)
+                # rollback catalog entry, suppress any errors raised by catalog
+                with contextlib.suppress(CatalogError):
+                    self.catalog().delete_table_catalog_entry(catalog_entry)
                 raise e

test/integration_tests/long/test_create_table_executor.py

@@ -63,7 +63,6 @@ def _test_currently_cannot_create_boolean_table(self):
         with self.assertRaises(ExecutorError):
             execute_query_fetch_all(self.evadb, query)
 
-    @macos_skip_marker
     def test_should_create_table_from_select(self):
         create_query = """CREATE TABLE dummy_table
             AS SELECT id, DummyObjectDetector(data).label FROM MyVideo;
@@ -113,6 +112,16 @@ def test_should_create_table_from_select_lateral_join(self):
         query = "CREATE TABLE IF NOT EXISTS " f"uadtrac_fastRCNN AS {select_query};"
         execute_query_fetch_all(self.evadb, query)
 
+    def test_create_table_with_incorrect_info(self):
+        create_table = "CREATE TABLE SlackCSV(metadata TEXT(1000));"
+        with self.assertRaises(Exception):
+            execute_query_fetch_all(self.evadb, create_table)
+
+        # running create table after fixing the error
+        create_table = "CREATE TABLE SlackCSV(user_profile TEXT(1000));"
+        execute_query_fetch_all(self.evadb, create_table)
+        execute_query_fetch_all(self.evadb, "DROP TABLE SlackCSV;")
+
 
 if __name__ == "__main__":
     unittest.main()