Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Documentation #100

Merged
merged 9 commits into from
Oct 28, 2020
Merged

Updated Documentation #100

merged 9 commits into from
Oct 28, 2020

Conversation

Abdullahshah
Copy link
Member

@Abdullahshah Abdullahshah commented Sep 3, 2020

Version 2 (current):
The api-docs now uses a new recursive way to find source code and build summary pages for them for our documentation. The only change moving forward would be to add a quick description in the __init__.py files for each module. An example would be:
__init__.py: """ A quick description of the module """

Sphinx auto-doc will take this string and set it as a quick description for the module's page.

To generate the documentation, navigate to eva/api-docs/ and run make clean && make html. This will create the HTML files under _build which you can use to view the changes locally. It also generates the .rst files under api-docs/_autosummary which are used by Spinx to generate the HTML content

Version 1 (OLD):
Created script generate_documentation.py which creates the documenation .rst using the jinja templating engine.
(this script can only be run from the root directory -> but there is a check for this in the script)

To test these changes, enter the conda environment, navigate to the directory api-docs and run make html. This will generate a local copy of the website under the directory _build which can be opened in the browser.

Copy link
Member

@gaurav274 gaurav274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the installation dependencies to build using sphinx .

api-docs/documentation_old/catalog/catalog.models.rst Outdated Show resolved Hide resolved
api-docs/generate_documentation.py Outdated Show resolved Hide resolved
api-docs/generate_documentation.py Outdated Show resolved Hide resolved
api-docs/generate_documentation.py Outdated Show resolved Hide resolved
api-docs/generate_documentation.py Outdated Show resolved Hide resolved
@Abdullahshah
Copy link
Member Author

No longer need generate_documentation.py. Deprecating that script for now but may need it later if api-docs needs further changes.

Copy link
Member Author

@Abdullahshah Abdullahshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the Conversation tab for updates to documentation process.

@github-pages github-pages bot temporarily deployed to github-pages October 9, 2020 03:08 Inactive
@gaurav274
Copy link
Member

@Abdullahshah Any updates on this PR? Let's merge this as early as possible.

@xzdandy
Copy link
Collaborator

xzdandy commented Oct 22, 2020

Add sphinx and sphinx_rtd_theme to conda environment file.

Copy link
Member

@gaurav274 gaurav274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaurav274 gaurav274 merged commit 3618f57 into master Oct 28, 2020
llxxll12345 pushed a commit that referenced this pull request Feb 15, 2021
@gaurav274 gaurav274 deleted the documentation branch March 25, 2021 06:41
luoj1 pushed a commit to luoj1/eva that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants