Modularized Parser #127
Merged
Modularized Parser #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzdandy
reviewed
Jan 8, 2021
| ddl_statement = self.visitChildren(ctx) | ||
| return ddl_statement | ||
|
|
||
| def visitDmlStatement(self, ctx: evaql_parser.DdlStatementContext): |
There was a problem hiding this comment.
What's the difference between visitDdlStatement on line 54?
There was a problem hiding this comment.
duplicate function, I'll remove one.
There was a problem hiding this comment.
Duplicate functions. I'll remove one
xzdandy
reviewed
Jan 8, 2021
|
|
||
| def visitLogicalExpression( | ||
| self, ctx: evaql_parser.LogicalExpressionContext): | ||
| if len(ctx.children) < 3: |
There was a problem hiding this comment.
LOGICAL_NOT only has 2 children
xzdandy
reviewed
Jan 8, 2021
| return ExpressionType.LOGICAL_OR | ||
| elif op == 'AND': | ||
| return ExpressionType.LOGICAL_AND | ||
| else: |
There was a problem hiding this comment.
I see we are not supporting NOT. I was thinking we have NOT supported, because https://github.com/georgia-tech-db/eva/blob/master/src/expression/logical_expression.py
There was a problem hiding this comment.
We are not yet. We will add when we need be.
|
@gaurav274 we need to merge this first. |
…tead of raw values
* Add .circleci/config.yml * Leave out the coverage report * allow sudo to carry user set env var * add pip missing packages * a working version build and test workflow * empty line * Just to trigger new build * integration with coveralls
xzdandy
approved these changes
Feb 22, 2021
xzdandy
added a commit
to gaurav274/Eva
that referenced
this pull request
Mar 19, 2022
Modularized Parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser modularized, moved from a single file to multiple modules