feat: Ray integration #621
Conversation
jiashenC
commented
Mar 23, 2023
•
jiashenC
commented
- Auto-detect availability of GPUs.
- Enable CircleCI auto-testing for Ray execution.
- Only test CPU Ray on CircleCI.
- Disable coverage report where it causes long hang for multi-process execution.
- Address integration test failures for Ray. Here are a list of causes that I address in this PR.
- Bug in Ray optimizer that does not correctly yield, which often results infinite loop in optimization step.
- A tree-like execution plan was not previously supported for Ray, mainly because the queue population does not support that yet. For a quick merge now, I do a post-processing to disable Exchange plan for all execution plans that have branch.
@gaurav274 I enable the circleci. It does not have GPU resource, so we need to change that as well. |
|
I think lateral join becomes linear now. So ray should be able to support function scan without worrying about tree-like execution plan. |
jiashenC
force-pushed
the
fix-ray
branch
2 times, most recently
from
4e08a14
to
9aa9fac
Compare
eva/optimizer/plan_generator.py
Outdated
| plan.append_child(child) | ||
|
|
||
| if isinstance(plan, ExchangePlan): | ||
| if is_top: |
There was a problem hiding this comment.
I think this code piece can be simplified. How about you assert on is_top and len(plan.children) == 1 and always return plan.children. This is also simplify the above check on List.
There was a problem hiding this comment.
Is this a temporary work around? I feel We should be able to support branch and createMat. But I agree it is not priority.
There was a problem hiding this comment.
Yes. This is temporary workaround as a quick way to support Ray. I agree we can definitely extend to more use cases.
| else: | ||
| upper = ExchangePlan( | ||
| parallelism=2, | ||
| ray_conf={"num_gpus": 1} |
There was a problem hiding this comment.
@kaushikravichandran This can be moved outside to a heuristic in a future PR.
|
Please add a test case where the |
|
@kaushikravichandran Let us wait for a few builds and then promote |
|
@xzdandy @gaurav274 Fix all comments. Should be ready. |
