Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restart eva_server process for every tutorial #752

Merged
merged 2 commits into from
May 22, 2023

Conversation

jiashenC
Copy link
Member

Currently, eva_server is not restarted when running a tutorial. In this case, if ~/.eva directory is deleted or modified by user, the eva_server process enters a not clean state.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jarulraj
Copy link
Member

jarulraj commented May 22, 2023

I did this to speed up CI for notebooks. Why do things not work in the notebook even if all the test cases pass?

@jiashenC
Copy link
Member Author

I did this to speed up CI for notebooks. Why do things not work in the notebook even if all the test cases pass?

It won't affect test cases across different tutorials. But when users delete or modify ~/.eva directory without restarting the eva_server process, I guess the process may cache database data in memory (e.g., image path) even though the dataset is already gone.

@gaurav274 gaurav274 merged commit 81a2ebd into master May 22, 2023
@gaurav274 gaurav274 deleted the fix-not-stop-server branch May 22, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants