Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for concurrent queries #170

Closed
gaurav274 opened this issue Jul 25, 2021 · 3 comments
Closed

Add support for concurrent queries #170

gaurav274 opened this issue Jul 25, 2021 · 3 comments
Assignees
Labels
Feature Request ✨ New feature or request

Comments

@gaurav274
Copy link
Member

In the current setup, we cannot run multiple queries even though the execute_async returns control to the user immediately. We need the execute_async to return a future or an id which the user can use to specify the query they want o spin on.
Adding support for this workflow using the following API changes.

  1. .execute_async() - returns a future
  2. .fetch_all(future) - returns all the rows
@gaurav274 gaurav274 added the Feature Request ✨ New feature or request label Jul 25, 2021
@gaurav274 gaurav274 linked a pull request Aug 1, 2021 that will close this issue
@gaurav274 gaurav274 reopened this Aug 1, 2021
@jarulraj
Copy link
Member

jarulraj commented May 8, 2023

This is supported now. @xzdandy Can you please confirm?

@xzdandy xzdandy self-assigned this May 14, 2023
@xzdandy
Copy link
Collaborator

xzdandy commented May 14, 2023

@jarulraj I don't think we support concurrent queries now in EVA. Instead, we raise an explicit error when user issues concurrent queries. https://github.com/georgia-tech-db/eva/blob/96305640bbd0c4b85eb104c62c089d361260fb26/eva/server/db_api.py#L45
And I don't think this feature is a priority for us now. Maybe we can label this low priority.

@jarulraj
Copy link
Member

After my refactoring in Feb 23, we should be able to support two concurrent queries from two terminal clients. I think I left this message for two concurrent queries from a same terminal client. Can you please check?

@jarulraj jarulraj closed this as completed Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants