Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Automatically run black, flake8, isort via Github Action #103

Closed
benjaminye opened this issue Apr 2, 2024 · 3 comments · Fixed by #116
Closed

[Workflow] Automatically run black, flake8, isort via Github Action #103

benjaminye opened this issue Apr 2, 2024 · 3 comments · Fixed by #116
Assignees
Labels
enhancement New feature or request

Comments

@benjaminye
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  • Automatic formatting and linting to improve code consistency

Describe the solution you'd like

  • Have pre-commit hooks that run before commits
  • Example

Describe alternatives you've considered

  • I've been manually running black from time to time on the whole repo, but not the best solution for collaboration
@benjaminye benjaminye added the enhancement New feature or request label Apr 2, 2024
@benjaminye
Copy link
Contributor Author

@truskovskiyk
Copy link
Contributor

@benjaminye, It might not be pre-commit hooks, but just CI check that we pass the style. Not bug fun of pre-commit hooks to be honest

@benjaminye benjaminye changed the title [Workflow] Automatically run black, flake8, isort via pre-commit hooks [Workflow] Automatically run black, flake8, isort via Github Action Apr 2, 2024
@benjaminye benjaminye linked a pull request Apr 3, 2024 that will close this issue
@benjaminye
Copy link
Contributor Author

Closed as implemented by #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants