Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a small mistake in tabular_combiner.py #9

Closed
weibobo2015 opened this issue Nov 16, 2021 · 0 comments · Fixed by #31
Closed

There is a small mistake in tabular_combiner.py #9

weibobo2015 opened this issue Nov 16, 2021 · 0 comments · Fixed by #31

Comments

@weibobo2015
Copy link

As the title says, there is a mistake in tabular_combiner.py.
Line 409:
g_num = (torch.cat([w_text, w_cat], dim=-1) * self.weight_a).sum(dim=1).unsqueeze(0).T

should change to:
g_num = (torch.cat([w_text, w_num], dim=-1) * self.weight_a).sum(dim=1).unsqueeze(0).T

because it is in a numerical part which should use w_num instead of w_cat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant