Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Commit

Permalink
Removing __repr__ on DataCleaner as new get_params handles it
Browse files Browse the repository at this point in the history
  • Loading branch information
cchoquette committed Aug 7, 2019
1 parent 498b1c4 commit 94ef136
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 17 deletions.
16 changes: 0 additions & 16 deletions foreshadow/steps/cleaner.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,3 @@ def get_mapping(self, X):
],
cols=X.columns,
)

# def __repr__(self):
# """Return string representation of this object with parent params.
#
# Returns:
# See above.
#
# """
# r = super().__repr__()
# preparer_params = self._preparer_params()
# preparer_params = {p: getattr(self, p, None)
# for p in preparer_params}
# preparer_print = ", ".join(
# ["{}={}".format(k, v) for k, v in preparer_params.items()]
# )
# return r[:-1] + preparer_print + ")"
3 changes: 2 additions & 1 deletion foreshadow/wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ def get_params(self, deep=True):
# so we set them with the values on the object instance, below.
try:
self_params = super().get_params(deep=deep)
except RuntimeError:
except RuntimeError as e:
print(e)
# TODO, Chris explain why we copy scikit-learn's internal
# get_params.
self_params = dict() # the output
Expand Down

0 comments on commit 94ef136

Please sign in to comment.