Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Commit

Permalink
Adding _parallel_process to params.
Browse files Browse the repository at this point in the history
  • Loading branch information
cchoquette committed Aug 7, 2019
1 parent acd6542 commit f39736d
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 14 deletions.
29 changes: 15 additions & 14 deletions foreshadow/steps/cleaner.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,18 @@ def get_mapping(self, X):
cols=X.columns,
)

def __repr__(self):
"""Return string representation of this object with parent params.
Returns:
See above.
"""
r = super().__repr__()
preparer_params = self._preparer_params()
preparer_params = {p: getattr(self, p, None) for p in preparer_params}
preparer_print = ", ".join(
["{}={}".format(k, v) for k, v in preparer_params.items()]
)
return r[:-1] + preparer_print + ")"
# def __repr__(self):
# """Return string representation of this object with parent params.
#
# Returns:
# See above.
#
# """
# r = super().__repr__()
# preparer_params = self._preparer_params()
# preparer_params = {p: getattr(self, p, None)
# for p in preparer_params}
# preparer_print = ", ".join(
# ["{}={}".format(k, v) for k, v in preparer_params.items()]
# )
# return r[:-1] + preparer_print + ")"
36 changes: 36 additions & 0 deletions foreshadow/steps/preparerstep.py
Original file line number Diff line number Diff line change
Expand Up @@ -536,3 +536,39 @@ def _preparer_params():
if p.name != "self" and p.kind != p.VAR_KEYWORD
]
return [p.name for p in parameters]

def get_params(self, deep=True):
"""See super.
Overridden to add this parent classes' params to children and to
include _parallel_process
Args:
deep: See super.
Returns:
See super.
"""
params = super().get_params(deep=deep)
_preparer_params = self._preparer_params()
params.update(
{key: getattr(self, key, None) for key in _preparer_params}
)
params.update(
{"_parallel_process": getattr(self, "_parallel_process", None)}
)
return params

def set_params(self, **params):
"""See super.
Overridden to afld this parent classes' params to children and to
include _parallel_process
Args:
**params: see super.
"""
self._parallel_process = params.pop("_parallel_process", None)
super().set_params(**params)

0 comments on commit f39736d

Please sign in to comment.