Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TYPO3 Exception if the target of a external link is _top or _self #1

Closed
Patta opened this issue Jul 19, 2019 · 1 comment
Closed

Comments

@Patta
Copy link

Patta commented Jul 19, 2019

If the target value of a external link is _top or _self a uncaught TYPO3 exception error is shown.

Core: Exception handler (WEB): Uncaught TYPO3 Exception: Return value of GeorgRinger\Noopener\Hooks\LinkHook::checkSysDomains() must be of the type bool, null returned | TypeError thrown in file /var/www/vhosts/###REMOVED###/private/typo3conf/ext/noopener/Classes/Hooks/LinkHook.php in line 150. Requested URL: ###REMOVED###

Why _top or _self on a external link?
We host a url shortener and link to a shorten url which redirect to the same domain and don't need a new tab.

TYPO3 8.7.27
PHP 7.3.7
Composer mode
noopener dev-master

Thanks for this must-have extension.

@Patta
Copy link
Author

Patta commented Nov 14, 2019

fixed with 56e37f5

@Patta Patta closed this as completed Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant