Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please delete #7

Closed
schumiel opened this issue Mar 27, 2020 · 2 comments
Closed

please delete #7

schumiel opened this issue Mar 27, 2020 · 2 comments

Comments

@schumiel
Copy link

schumiel commented Mar 27, 2020

please delete

@BastianBalthasarBux
Copy link

BastianBalthasarBux commented Mar 27, 2020

Your message is more than offensive, maybe you should rethink your attitude. If I was Georg, I would now be really unmotivated and just stop my free work on that, and maybe even hide the repo from the public.

To the question, it's pretty easy to answer.

  1. If one writes HTML in a template, we should be allowed to expect this one has got more brain than 2m of a country lane. Thus we could expect, this one writes the rel attribute correctly and savely in exactly the way it should appear.

  2. Nevertheless what you want could have been done, but in a completely different way. Georg hooked into the ContentObjectRenderer. That means, the rel-attribute gets added with some sanitation logic on a relatively early stage of generating the page.
    What you want, would mean to reparse the whole page after it got created, like e.g. extension sourceopt does. This has several significant disadvantages in this case, e.g. you would need maybe a regex to find URLs (which is also error-prone), you must completely test them on your own if they are internally/externally, relative etc...
    This would also be pretty in-performant and would need a full bloated bunch of code. All for the sake, that some moron who thinks to be able to write correct HTML is not aware that he/she is not.

@schumiel
Copy link
Author

Wow, no. My questions were not intended to attack Georg. I just wanted to know why and why. Just to know how complex this would be. Not in the beginning I wanted something bad with my questions. I apologize if this has been interpreted in this way. But it wasn't in my interest.

Please close / delete thread.

@schumiel schumiel changed the title Doesn't work with templates please delete Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants