Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polylabel #65

Closed
urschrei opened this issue Aug 26, 2016 · 1 comment
Closed

Polylabel #65

urschrei opened this issue Aug 26, 2016 · 1 comment

Comments

@urschrei
Copy link
Member

I've implemented the very nice Mapbox Polylabel algorithm for optimised polygon label placement, here: https://github.com/urschrei/polylabel-rs

I think it should be part of georust. If you agree, should it be:

  • an impl on Polygon within rust-geo
    • Should it have the same name, or a different name?
  • a separate crate, like Polyline
@frewsxcv
Copy link
Member

frewsxcv commented Sep 2, 2016

Sorry for the delay, but busy recently. In my opinion, I think this algorithm is specific enough that it should probably live in a separate crate. My thinking is that rust-geo should only contain the core primitive algorithms that other crates can build on top of. What do you think? If you're wanting to move the crate to the GeoRust organization (you don't have to if you don't want to), feel free to do so. Nice job by the way, that crate looks great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants