Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option or default language=native (Opencage) #37

Closed
terry90 opened this issue Jun 15, 2020 · 2 comments · Fixed by #38
Closed

Add option or default language=native (Opencage) #37

terry90 opened this issue Jun 15, 2020 · 2 comments · Fixed by #38

Comments

@terry90
Copy link
Contributor

terry90 commented Jun 15, 2020

It's not uncommon to use the location's native language when geocoding (especially for forward geocoding).
Could we consider adding this as a default ? or would it be better to make it an optional parameter ?

@freyfogle
Copy link
Contributor

As someone who lives in Barcelona I can tell you there are cases where it is highly contentious what the "native" language is.

In the case of OSM supplying "native" returns non-intuitive results. For example the "native" name for Belgium is a concatenation of all three languages of Belgium ie België / Belgique / Belgien Probably the only thing all three groups can agree on is that that is not correct ;-)

At OpenCage we take the approach of
a. obey whatever the user explicitly defined (which can also be language=native)
b. obey the browser language
c. default to English

https://opencagedata.com/api#language

@terry90
Copy link
Contributor Author

terry90 commented Jun 15, 2020

Sure, but for now it's not even possible to chose the language when geocoding with this crate. I understand the case of non-intuitive native languages though.
I'll write a PR for this if this is OK. something to provide optional parameters, with defaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants