Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace get_epsilon with f64 EPSILON #1

Open
stonylohr opened this issue Jul 13, 2020 · 1 comment
Open

replace get_epsilon with f64 EPSILON #1

stonylohr opened this issue Jul 13, 2020 · 1 comment

Comments

@stonylohr
Copy link
Contributor

geomath::get_epsilon is calculating a value that rust already has available as the constant f64::EPSILON. It would be preferable to reference that constant directly, rather than defining a function for it.
@Psykopear
Copy link
Contributor

Yes, you can open a PR with the fix

This was referenced Jan 23, 2021
Open
Open
@valarauca valarauca mentioned this issue Jan 20, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Psykopear @stonylohr