New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ergonomics and added features #21
Conversation
Thank you for the review @bluss! I think the PR is ready to be merged, and published to crates.io |
Nice. I'm just coaching here. Now that it's ready for merge, I'd go back to the PR title and description and edit them to make sure they match the updated content of the PR. For example, the title should be updated. I'd ask for a summary of removed, added and changed features. |
I'm good with 0.2.0. Thanks for all the feedback @bluss and awesome work @magnusuMET ! Just confirming one more time since there's been a little more action, are we ready to merge? |
We are almost ready, I would like to change the title and description for the PR |
Ok sounds good - @magnusuMET you should've received an invite from crates.io to allow you to publish the crate. This way you don't have to wait on me. |
@mhiley Updated and ready to merge! Still haven't gotten the invite, so you may go ahead and publish. |
Awesome work @magnusuMET and I really appreciate the time taken by @bluss in your detailed review; always learning from your contributions! 👏 |
published to crates.io as v0.2.0 and tagged repo v0.2.0 🎉 Let me know if there are any problems with the published crate. |
This PR makes the crate more ergonomic for users, and adds some missing functionality such as unlimited dimensions.
Removed:
Changed:
netcdf::Result
Added:
Path
-like itemDeref
andDerefMut
for the file makes adding and accessing variables/dimensions easier