Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement opaque types #33

Closed
magnusuMET opened this issue Oct 24, 2019 · 4 comments · Fixed by #61
Closed

implement opaque types #33

magnusuMET opened this issue Oct 24, 2019 · 4 comments · Fixed by #61

Comments

@magnusuMET
Copy link
Member

magnusuMET commented Oct 24, 2019

Add two new functions to Variable for putting and getting raw bytes

@lwandrebeck
Copy link
Contributor

There’s a WIP in https://github.com/lwandrebeck/rust-netcdf/commit/c69077643b1eb782f1a3eb7a43907058dfd657f4
Feel free to work on it a bit more, I probably won’t have much time in the coming days.

@magnusuMET
Copy link
Member Author

I think this might require quite a lot of work when it comes to exposing netcdf types as some sort of rust structure. I'm going to remove the "good first issue" tag.

The best thing would be to have a serde like approach to serialising data, where one can put a #derive(netcdf) on a struct, but I haven't really had a look at how that is done.

@magnusuMET magnusuMET removed the good first issue good for newcomers label Oct 28, 2019
@magnusuMET
Copy link
Member Author

We need to add a Vec or HashMap to store the types in each Group, and some way of using the generic Numeric trait on the custom types.

@magnusuMET
Copy link
Member Author

#37 allows us to traverse the tree upwards to get any types. Each variable now needs a weakref to the group, and we can find the applicable type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants