Implemented "Closest Point" from a Point on a Geometry using spherical geometry.
#958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
requested changes
Jan 17, 2023
|
bors r=frewsxcv,michaelkirk
I'll follow up with an update to the docs - no need to make this PR wait even longer on account of me. |
2 tasks
|
There were some clippy errors too, due to a deprecation/rename that's happened in the meanwhile. Fixed in #1026. |
bors bot
added a commit
that referenced
this pull request
Jun 27, 2023
1026: haversine closest point fixups r=michaelkirk a=michaelkirk - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/main/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Addendum to #958 Co-authored-by: Branimir Betov <b_betov@yahoo.com> Co-authored-by: Corey Farwell <coreyf@rwell.org> Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Essentially implementing
ClosestPointtrait for spherical geometry. I named the new traitHaversineClosestPoint.There is a slight (intentional) difference in behavior in the case when a segment (arc)'s length is very close to zero, the spherical algorithm will return
Closest::SinglePointinstead ofClosest::Indeterminate. I think even if the segment has degenerated to a point, there is still a closest point.