Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use geo-types crate #12

Merged
merged 3 commits into from May 3, 2018
Merged

Use geo-types crate #12

merged 3 commits into from May 3, 2018

Conversation

groteworld
Copy link
Member

As mentioned in #11 there is a new low dependency crate for geo types.

There seemed to be an issue with serde.Deserialize trait and the new geo-types.Point. Review should be done to let me know what this could hurt in the future.

Unknown what this will directly effect, but there seems to be an issue
between in and geo_types.Point.
Seems to be caused by issues in geo to geo-types conversion
@groteworld groteworld requested a review from urschrei May 3, 2018 14:54
@groteworld
Copy link
Member Author

Error in question:

error[E0277]: the trait bound `geo_types::Point<T>: serde::Deserialize<'_>` is not satisfied
   --> src/opencage.rs:511:17
    |
511 | #[derive(Debug, Deserialize)]
    |                 ^^^^^^^^^^^ the trait `serde::Deserialize<'_>` is not implemented for `geo_types::Point<T>`
    |
    = note: required by `serde::de::SeqAccess::next_element`

@groteworld groteworld requested a review from frewsxcv May 3, 2018 14:59
@urschrei
Copy link
Member

urschrei commented May 3, 2018

Ah, that's because serde's optional in geo-types. It's probably OK to leave it out for now – I tend to add Deserialize out of habit when it's available.

@groteworld
Copy link
Member Author

I tend to add Deserialize out of habit when it's available.

I hear you, just wanted to make sure we didn't have a specific reason. Thanks @urschrei!

@groteworld
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request May 3, 2018
12: Use geo-types crate r=groteworld a=groteworld

As mentioned in #11 there is a new low dependency crate for geo types.

There seemed to be an issue with serde.Deserialize trait and the new geo-types.Point. Review should be done to let me know what this could hurt in the future.

Co-authored-by: Blake Grotewold <blake.grotewold@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 3, 2018

Build succeeded

@bors bors bot merged commit 6dca788 into master May 3, 2018
@groteworld groteworld deleted the feature/use-geo_types-crate branch May 3, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants