Do not crash if a gpx file has an extensions tag in its route tag #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agateau
force-pushed
the
support-route-extensions
branch
from
c4d7507
to
236dc24
Compare
|
bors try |
tryBuild succeeded: |
|
Thanks for this, @agateau. I'm happy to merge, but if you have a smaller GPX source to test with that would be great. |
The extensions tag is also allowed in the route tag (see https://www.topografix.com/GPX/1/1/#type_rteType)
agateau
force-pushed
the
support-route-extensions
branch
from
236dc24
to
290f39f
Compare
Sure, I just force-pushed a much shorter GPX file. |
|
bors try |
tryBuild succeeded: |
|
Bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extensions tag is also allowed in the route tag (see https://www.topografix.com/GPX/1/1/#type_rteType).
CHANGELOG.mdif knowledge of this change could be valuable to users.