Basic error handling for en– and decoding #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encode_coordinates() and decode_polyline() now cope with the possibility that a u32 can't be encoded as a char, or that your .nth() operation could fail because index is longer than the iterator (the latter is unlikely, but here we are) This also means that your public functions now return Result types, which allows their consumers to be a bit more flexible.
This removes some manual assignments, manual indexing, and substitutes a proper check for emptiness
|
Amazing, thanks! This teaches me a new part of Rust :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encode_coordinates()anddecode_polyline()now cope with thepossibility that a u32 can't be encoded as a char, or that your
.nth()operation could fail because
indexis longer thanstr(the latter is unlikely, but here we are).
This also means that your public functions now return
Resulttypes,which allows their consumers to be a bit more flexible.