Tests for invalid input strings, and bounds checks for coordinates #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no point in attempting to encode invalid latitude or longitude coordinates. The function's error value is the input, which we're converting to an informative error message. One drawback is the fact that encoding will now fail on the first error; A more flexible approach would be to first check the values, and if the vector contains errors, to extract them and their positions into the Err. 🤔
|
|
||
| const MIN_LONGITUDE: f64 = -180.; | ||
| const MAX_LONGITUDE: f64 = 180.; | ||
| const MIN_LATITUDE: f64 = -90.0; |
There was a problem hiding this comment.
Should these all end with . or should they all have .0?
There was a problem hiding this comment.
You can leave off the trailing 0, but I like to be consistent. Will push a fix shortly.
|
👍 awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the last of the
unwrap()calls (forgot to push that commit last time – sorry) and adds: