Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Display for Wkt #86

Merged
merged 3 commits into from Apr 2, 2022
Merged

Conversation

categulario
Copy link
Contributor

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

to address #83 and make it easier to go from Wkt to string representation. Includes test

Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll wait a couple days before merging in case anybody else wants to weigh in.

bors try

bors bot added a commit that referenced this pull request Apr 1, 2022
@bors
Copy link
Contributor

bors bot commented Apr 1, 2022

try

Build failed:

@michaelkirk
Copy link
Member

Could you please run cargo fmt and push up the changes?

@categulario
Copy link
Contributor Author

Done!

categulario added a commit to categulario/wkt that referenced this pull request Apr 1, 2022
This requires Display to be implemented (see georust#86) but it shows something
that otherwise is quite hard to learn how to do.
@categulario categulario mentioned this pull request Apr 1, 2022
3 tasks
@lnicola
Copy link
Member

lnicola commented Apr 2, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 2, 2022

Build succeeded:

@bors bors bot merged commit 83294e0 into georust:main Apr 2, 2022
categulario added a commit to categulario/wkt that referenced this pull request Apr 3, 2022
This requires Display to be implemented (see georust#86) but it shows something
that otherwise is quite hard to learn how to do.
bors bot added a commit that referenced this pull request Apr 14, 2022
89: Easier serialization of wkt with ToWkt::wkt_string/write_wkt r=urschrei a=michaelkirk

- [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md).
- [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
- [x] I ran cargo fmt
---
Fixes #55 - adds an easier API to serialize a geo-type.

~~Depends on #86, so merge that first.~~ Merged!

~~partially conflicts with #88, because I'm relying on the `ToWkt` trait.~~ superseded!


Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
@michaelkirk michaelkirk mentioned this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants