WIP: Impl/from geo types #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it also addresses #55 |
3 tasks
|
I'm curious what you though of my proposal in #89 @categulario |
|
With |
Closed
This requires Display to be implemented (see georust#86) but it shows something that otherwise is quite hard to learn how to do.
categulario
force-pushed
the
impl/from-geo-types
branch
from
04d56ff
to
3a76064
Compare
|
Just pushed some commits and rebased main. ToWkt is restored but deprecated. The doc tests are fixed. |
|
Closing this since it no longer reflects my ideas, mostly laid out in #73 |
bors bot
added a commit
that referenced
this pull request
Apr 14, 2022
89: Easier serialization of wkt with ToWkt::wkt_string/write_wkt r=urschrei a=michaelkirk - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. - [x] I ran cargo fmt --- Fixes #55 - adds an easier API to serialize a geo-type. ~~Depends on #86, so merge that first.~~ Merged! ~~partially conflicts with #88, because I'm relying on the `ToWkt` trait.~~ superseded! Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.addresses #73 and #48.
This adds impls of From for every type and the Geometry enum in
geo_types. It makes it unnecessary to bring to scope the ToWkt trait which gets deleted because it was not being used actually. Of course this is a breaking change.Additionally I added some docs on the most relevant cases for this crate: parsing a wkt and getting a geometry and having a geometry and getting its WKT string. This is what actually motivates most of the PRs I've been doing, I just wanted to do that .-.
Some opinions
What if Wkt was instead a trait itself, implemented for every type in
geo_typesthat provided a single method:wkt(&self) -> String?being
georustan environment for building geo applications it makes sense that things are integrated to work well within the environment, and maybe providing someLineStringetc. traits which, if implemented on foreign types would give automatically aWktimpl that allows to get its WKT string. And perhaps aWktGeometryenum with inner types refering to those in thegeo_typescrate just for the purposes of having something to parse a string into. Although it probably makes more sense to just haveFromStrimpls for thegeo_typesthemselves...Just an idea, I think it would simplify a lot how work with this crate happens.
This actually requires #86 for the docs to pass the tests