-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding check and warning message for defaultThermalExpansionCoefficient #2407
Comments
Indeed, they are two different coefficients both are required for simulating a THM coupling problem. Precisely, the I would propose to change their name and description a little bit to clarify that they are not the same thing. There is also another one in @francoishamon @jhuang2601 How do you think about rename them as: |
@sytuannguyen Concur with you on such necessary update. |
@francoishamon How do you think about this change? |
…nt (#2809) There are two different Thermal Expansion Coefficients (TEC), one for updating stress/strain and one for updating the porosity w.r.t temperature change. Actually a same name is used for these two TEC in the input XML interface. This PR aims to specify two different name for these two different parameters to avoid potential user confusion as shown in the issue #2407 .
…nt (#2809) There are two different Thermal Expansion Coefficients (TEC), one for updating stress/strain and one for updating the porosity w.r.t temperature change. Actually a same name is used for these two TEC in the input XML interface. This PR aims to specify two different name for these two different parameters to avoid potential user confusion as shown in the issue #2407 .
What is the requested feature?
Currently,
defaultThermalExpansionCoefficient
needs to be defined separately in both the solid model and theBiotPorosity
model for THM simulations. Different formulas might be used in different sections within the same xml file by end users. Sanity check is missing to protect GEOS from inconsistent or incomplete input.Is your request related to a specific problem?
![image](https://user-images.githubusercontent.com/53012159/234130035-68f40885-a4c2-40f4-ad87-73ed2effcb7d.png)
For this tutorial example, if
defaultThermalExpansionCoefficient
is missing in theBiotPorosity
model, simulation results deviate away from the corresponding analytical solution.Describe the solution you'd like
Sanity check and warning message are expected for
defaultThermalExpansionCoefficient
and related theory ofBiotPorosity
model should also be updated.The text was updated successfully, but these errors were encountered: