Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding check and warning message for defaultThermalExpansionCoefficient #2407

Closed
jhuang2601 opened this issue Apr 24, 2023 · 3 comments · Fixed by #2809
Closed

Adding check and warning message for defaultThermalExpansionCoefficient #2407

jhuang2601 opened this issue Apr 24, 2023 · 3 comments · Fixed by #2809
Assignees
Labels
type: feature New feature or request

Comments

@jhuang2601
Copy link
Contributor

jhuang2601 commented Apr 24, 2023

What is the requested feature?
Currently, defaultThermalExpansionCoefficient needs to be defined separately in both the solid model and the BiotPorosity model for THM simulations. Different formulas might be used in different sections within the same xml file by end users. Sanity check is missing to protect GEOS from inconsistent or incomplete input.

Is your request related to a specific problem?
For this tutorial example, if defaultThermalExpansionCoefficient is missing in the BiotPorosity model, simulation results deviate away from the corresponding analytical solution.
image

Describe the solution you'd like
Sanity check and warning message are expected for defaultThermalExpansionCoefficient and related theory of BiotPorosity model should also be updated.

@jhuang2601 jhuang2601 added type: feature New feature or request type: new A new issue has been created and requires attention labels Apr 24, 2023
@TotoGaz TotoGaz removed the type: new A new issue has been created and requires attention label Jun 21, 2023
@sytuannguyen
Copy link
Contributor

Indeed, they are two different coefficients both are required for simulating a THM coupling problem. Precisely, the defaultThermalExpansionCoefficient in the solid model is the drained linear TEC that related temperature change with strain in a drained free stress test while the one in BiotPorosity is another one for computing porosity variation due to temperature change in a drained free stress test.

I would propose to change their name and description a little bit to clarify that they are not the same thing. There is also another one in ThermalCompressibleSinglePhaseFluid that is the thermal expansion coefficient of fluid.

@francoishamon @jhuang2601 How do you think about rename them as: defaultDrainedThermalExpansionCoefficient in the solid model, defaultPosorityThermalExpansionCoefficient in the BiotPorosity model, defaultFluidThermalExpansionCoefficient in the fluid model.

@jhuang2601
Copy link
Contributor Author

Indeed, they are two different coefficients both are required for simulating a THM coupling problem. Precisely, the defaultThermalExpansionCoefficient in the solid model is the drained linear TEC that related temperature change with strain in a drained free stress test while the one in BiotPorosity is another one for computing porosity variation due to temperature change in a drained free stress test.

I would propose to change their name and description a little bit to clarify that they are not the same thing. There is also another one in ThermalCompressibleSinglePhaseFluid that is the thermal expansion coefficient of fluid.

@francoishamon @jhuang2601 How do you think about rename them as: defaultDrainedThermalExpansionCoefficient in the solid model, defaultPosorityThermalExpansionCoefficient in the BiotPorosity model, defaultFluidThermalExpansionCoefficient in the fluid model.

@sytuannguyen Concur with you on such necessary update.

@sytuannguyen
Copy link
Contributor

Indeed, they are two different coefficients both are required for simulating a THM coupling problem. Precisely, the defaultThermalExpansionCoefficient in the solid model is the drained linear TEC that related temperature change with strain in a drained free stress test while the one in BiotPorosity is another one for computing porosity variation due to temperature change in a drained free stress test.
I would propose to change their name and description a little bit to clarify that they are not the same thing. There is also another one in ThermalCompressibleSinglePhaseFluid that is the thermal expansion coefficient of fluid.
@francoishamon @jhuang2601 How do you think about rename them as: defaultDrainedThermalExpansionCoefficient in the solid model, defaultPosorityThermalExpansionCoefficient in the BiotPorosity model, defaultFluidThermalExpansionCoefficient in the fluid model.

@sytuannguyen Concur with you on such necessary update.

@francoishamon How do you think about this change?

@sytuannguyen sytuannguyen linked a pull request Nov 8, 2023 that will close this issue
TotoGaz pushed a commit that referenced this issue Dec 13, 2023
…nt (#2809)

There are two different Thermal Expansion Coefficients (TEC), one for updating stress/strain and one for updating the porosity w.r.t temperature change. Actually a same name is used for these two TEC in the input XML interface.

This PR aims to specify two different name for these two different parameters to avoid potential user confusion as shown in the issue #2407 .
ouassimkh pushed a commit that referenced this issue Feb 16, 2024
…nt (#2809)

There are two different Thermal Expansion Coefficients (TEC), one for updating stress/strain and one for updating the porosity w.r.t temperature change. Actually a same name is used for these two TEC in the input XML interface.

This PR aims to specify two different name for these two different parameters to avoid potential user confusion as shown in the issue #2407 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants