Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add OH metrics output for benchmarks #34

Closed
msulprizio opened this issue Sep 10, 2019 · 5 comments
Closed

[FEATURE REQUEST] Add OH metrics output for benchmarks #34

msulprizio opened this issue Sep 10, 2019 · 5 comments
Assignees
Labels
category: Feature Request New feature or request

Comments

@msulprizio
Copy link
Contributor

Reproduce the GAMAP metrics output in GCPy so that we do not need to generate with IDL. Ideally, we would compute and compare global mean OH, MCF lifetime, and CH4 lifetime.

@msulprizio msulprizio added the category: Feature Request New feature or request label Sep 10, 2019
@msulprizio msulprizio self-assigned this Sep 10, 2019
@msulprizio msulprizio removed the category: Feature Request New feature or request label Sep 10, 2019
@msulprizio
Copy link
Contributor Author

The calculations for MCF and CH4 lifetimes require the time-in-troposphere diagnostic output from GEOS-Chem. This is currently only saved out to bpch diagnostics and needs to be implemented in History. @yantosca is working on that now.

@yantosca
Copy link
Contributor

The time in troposphere netCDF diagnostic is now implemented in commit geoschem/geos-chem@c01871c.

A 1-day zonal mean of ND54 (bpch) vs. FracOfTimeInTrop (netCDF) looks like this:
timeintrop

@msulprizio
Copy link
Contributor Author

This is now pushed in 509cb4f.

We still need to apply fraction of time in troposphere to calculation to include only purely tropospheric boxes. This will be added once the 12.6.0 1-month benchmark with the new FracOfTimeInTrop diagnostic is available.

@msulprizio msulprizio changed the title [FEATURE REQUEST] Add metrics output for benchmarks [FEATURE REQUEST] Add OH metrics output for benchmarks Sep 19, 2019
@msulprizio
Copy link
Contributor Author

msulprizio commented Sep 19, 2019

This calculation now also works for GCHP but the values are off. For example,

### Global mass-weighted OH concentration [1e5 molec/cm3]                   ###
### Ref = GC_12.6.0; Dev = GCHP_12.6.0                                      ###
###############################################################################
  Ref          Dev          Dev - Ref    % diff     
  12.213840    60.125135    47.911295   392.2705

###############################################################################
### MCF lifetime w/r/t tropospheric OH [years]                              ###
### Ref = GC_12.6.0; Dev = GCHP_12.6.0                                      ###
###############################################################################
  Ref          Dev          Dev - Ref    % diff     
   5.339524     0.000000     0.000000     0.0000

###############################################################################
### CH4 lifetime w/r/t tropospheric OH [years]                              ###
### Ref = GC_12.6.0; Dev = GCHP_12.6.0                                      ###
###############################################################################
  Ref          Dev          Dev - Ref    % diff     
   8.980075     0.000000     0.000000     0.0000

Further investigation is required.

@yantosca yantosca added the category: Feature Request New feature or request label Oct 17, 2019
@yantosca
Copy link
Contributor

We should probably implement this as a HISTORY diagnostic in GEOS-Chem, so that we can obtain the output for GCHP as well. This is documented in GEOS-Chem pull request https://github.com/geoschem/geos-chem/242.

As a stopgap measure, I also have implemented a GCPy function (mean_oh_from_logs.py) to strip the 1-year mean OH from the log files and to print them. But this will not work for GCHP.

I will close out this issue, as it seems that further work will need to be done as a GEOS-Chem diagnostic as described in the issue above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants