Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign a very high absolute tolerance to prod/loss family species in KPP-built mechanisms #1753

Open
1 task done
yantosca opened this issue Apr 14, 2023 · 1 comment · Fixed by #2359
Open
1 task done
Assignees
Labels
category: Feature Request New feature or request topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms
Milestone

Comments

@yantosca
Copy link
Contributor

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

New GEOS-Chem feature or discussion

On the KPP repository there has been some discussion into preventing prod/loss species from affecting the error norm. One recommendation from @obin1 is to set the absolute tolerance ATOL of prod/loss species to an extremely high value.:

Here's a visualization from a project @msl3v and I've been working on: giving prod/loss species arbitrarily large absolute tolerances of 1e25 (effectively removing them from the error norm) reduces the number of integration steps. This can also slightly alter the concentrations of species whose tolerances we don't modify, by changing the internal timesteps. visualizePL

Because the error norm is used to compute KPP internal integration timesteps, this could reduce the amount of time spent in the integrator. As time allows, we might want to try implementing this recommendation in GEOS-Chem.

Tagging @msl3v @obin1 @RolfSander @msulprizio @jimmielin @lizziel @christophkeller for reference.

@obin1
Copy link

obin1 commented Jun 14, 2024

Moving to this issue regarding a potential fix specific to GEOS-Chem, Bob suggested on the KPP repository:

Another suggestion is to add entries for ATOL to the GEOS-Chem species_database.yml file, which could be read into the State_Chm%SpcData object (and then have a default ATOL if one is not specified). That would also be easy to implement.

I'm very much in favor of species-level RTOL and ATOL in species_database.yml, this would be nice to specify at run time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms
Projects
None yet
2 participants