Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obspack in Flexgrid model (v12.7.0) [BUG/ISSUE] #337

Closed
lshen2009 opened this issue Jun 1, 2020 · 10 comments
Closed

Obspack in Flexgrid model (v12.7.0) [BUG/ISSUE] #337

lshen2009 opened this issue Jun 1, 2020 · 10 comments
Assignees
Labels
category: Bug Something isn't working topic: Nested Grid Simulation Related to GEOS-Chem nested model simulations
Milestone

Comments

@lshen2009
Copy link

lshen2009 commented Jun 1, 2020

When I turn on the obspack in CH4 simulations, nothing is archived. I am using the Flexigrid (12.7.0) model. I think the problem is caused by a bug in the input_mod.F related to reading the obspack in the flexgrid model.

%%% OBSPACK MENU %%%    :
Turn on ObsPack diag?   : T
Quiet logfile output    : T

But when I go to main.F, and add this

print *, 'lshen_Input_Opt%Do_ObsPack',Input_Opt%Do_ObsPack

it prints 'F'.

Here is my run directory in Cannon /n/holyscratch01/jacob_lab/lshen/CH4/GEOS-Chem/Flexgrid/Global_4x5_obspack
My code ./CodeDir

Thanks.

@lshen2009 lshen2009 added the category: Bug Something isn't working label Jun 1, 2020
@yantosca
Copy link
Contributor

yantosca commented Jun 1, 2020

Thanks for writing. Can you first try recompiling & rerunning with the debug flags on to see if there isn't an out-of-bounds error that is tripping the flag? Use DEBUG=y BOUNDS=y FPEX=y.

@yantosca yantosca self-assigned this Jun 1, 2020
@lshen2009
Copy link
Author

I just tried and there isn't an out-of-bounds error. But this bug still exists. I printed it in input_mod.F.
Input_Opt%Do_ObsPack F

@yantosca
Copy link
Contributor

yantosca commented Jun 1, 2020

Which log file shows the error in your run directory?

@lshen2009
Copy link
Author

I submit the job run.sh
The output is in log.merra2

Thanks.

@yantosca
Copy link
Contributor

yantosca commented Jun 1, 2020

Thanks for writing. I think the call to READ_OBSPACK_MENU was somehow removed from routine READ_INPUT_FILE, perhaps in a Git merge. That seems to be why we are not reading the OBSPACK menu.

@msulprizio is more familiar with the CH4 code than I am but I wonder if this is also in the standard code. We can push a fix in 12.9.0.

1 similar comment
@yantosca
Copy link
Contributor

yantosca commented Jun 2, 2020

Thanks for writing. I think the call to READ_OBSPACK_MENU was somehow removed from routine READ_INPUT_FILE, perhaps in a Git merge. That seems to be why we are not reading the OBSPACK menu.

@msulprizio is more familiar with the CH4 code than I am but I wonder if this is also in the standard code. We can push a fix in 12.9.0.

@lshen2009
Copy link
Author

Thanks, Bob. Should I contact Melissa about how to fix this bug? Thanks.

@msulprizio
Copy link
Contributor

@lshen2009 I can add a fix to our methane workflow code

@yantosca
Copy link
Contributor

yantosca commented Jun 2, 2020

I'll add a fix for this into 12.9.0. We just have to add the call to READ_OBSPACK_MENU from routine READ_INPUT_FILE in input_mod.F (or *.F90, depending on the version). This seems to have been removed inadvertently in a Git merge. My apologies.

@yantosca yantosca added this to the 12.9.0 milestone Jun 2, 2020
@msulprizio
Copy link
Contributor

This is now resolved in commit ca14071 and will be included in 12.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working topic: Nested Grid Simulation Related to GEOS-Chem nested model simulations
Projects
None yet
Development

No branches or pull requests

3 participants