[BUG/ISSUE] State_Diag%JvalO3O1D and State_Diag%JvalO3O3P were not getting zeroed in flexchem_mod.F90

[yantosca]

This issue came out of the discussion in #804.

Lizzie Lundgren wrote:

I quickly looked at the code and it appears the new J-value diagnostics are not set to zero the way the old ones are. See

geos-chem/GeosCore/flexchem_mod.F90

Lines 244 to 263 in d7baeb8

	! Zero diagnostic archival arrays to make sure that we don't have any
	! leftover values from the last timestep near the top of the chemgrid
	IF (State_Diag%Archive_Loss ) State_Diag%Loss = 0.0_f4
	IF (State_Diag%Archive_Prod ) State_Diag%Prod = 0.0_f4
	IF (State_Diag%Archive_Jval ) State_Diag%Jval = 0.0_f4
	IF (State_Diag%Archive_JNoon ) State_Diag%JNoon = 0.0_f4
	IF (State_Diag%Archive_ProdCOfromCH4 ) State_Diag%ProdCOfromCH4 = 0.0_f4
	IF (State_Diag%Archive_ProdCOfromNMVOC) State_Diag%ProdCOfromNMVOC= 0.0_f4
	IF (State_Diag%Archive_OHreactivity ) State_Diag%OHreactivity = 0.0_f4
	IF (State_Diag%Archive_RxnRate ) State_Diag%RxnRate = 0.0_f4
	IF (State_Diag%Archive_KppDiags) THEN
	IF (State_Diag%Archive_KppIntCounts) State_Diag%KppIntCounts = 0.0_f4
	IF (State_Diag%Archive_KppJacCounts) State_Diag%KppJacCounts = 0.0_f4
	IF (State_Diag%Archive_KppTotSteps ) State_Diag%KppTotSteps = 0.0_f4
	IF (State_Diag%Archive_KppAccSteps ) State_Diag%KppAccSteps = 0.0_f4
	IF (State_Diag%Archive_KppRejSteps ) State_Diag%KppRejSteps = 0.0_f4
	IF (State_Diag%Archive_KppLuDecomps) State_Diag%KppLuDecomps = 0.0_f4
	IF (State_Diag%Archive_KppSubsts ) State_Diag%KppSubsts = 0.0_f4
	IF (State_Diag%Archive_KppSmDecomps) State_Diag%KppSmDecomps = 0.0_f4
	ENDIF

. That list of is missing the two new arrays.

[yantosca]

In commit 5cb62c8, we now have added the following code to make sure all relevant diagnostic arrays are zeroed in flexchem_mod.f90.

    IF (State_Diag%Archive_Jval           ) State_Diag%Jval           = 0.0_f4
    IF (State_Diag%Archive_Jval           ) State_Diag%JvalO3O1D      = 0.0_f4
    IF (State_Diag%Archive_Jval           ) State_Diag%JvalO3O3P      = 0.0_f4

This update has been added to the patch/13.2.1 branch. It will ship in version 13.2.1, which will be issued immediately after the 13.2.0 release.

NOTE: This fix does not resolve the issue of why these diagnostics may be lower than in previous versions. For that discussion, please see #804.