Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated download scripts to include wustl extdata mirror #832

Closed
wants to merge 1 commit into from

Conversation

LiamBindle
Copy link
Contributor

No description provided.

@msulprizio msulprizio added the topic: Input Data Related to input data label Aug 23, 2021
@msulprizio msulprizio added this to the 13.2.1 milestone Aug 23, 2021
Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LiamBindle These changes look fine to me. However, I would suggest changing the base branch to patch/13.2.1 since @yantosca made changes there to read input for download_data.py from a YML file. See commit fa5919c.

@LiamBindle LiamBindle changed the base branch from dev to patch/13.2.1 August 23, 2021 18:44
@LiamBindle LiamBindle changed the base branch from patch/13.2.1 to dev August 23, 2021 18:44
LiamBindle added a commit that referenced this pull request Aug 23, 2021
@LiamBindle
Copy link
Contributor Author

@msulprizio Thanks for point that out. It looks like @yantosca already updated download_data.py. I opened #832 which is this PR rebased on 13.2.1.

@LiamBindle LiamBindle closed this Aug 23, 2021
@LiamBindle LiamBindle deleted the feature/wustl-extdata-mirror branch August 23, 2021 19:27
LiamBindle added a commit that referenced this pull request Aug 23, 2021
LiamBindle added a commit that referenced this pull request Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: Input Data Related to input data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants