Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/ISSUE] Wrong precision used for MO2 + HO2 reaction in fullchem.eqn #951

Closed
yantosca opened this issue Oct 12, 2021 · 4 comments · Fixed by #952
Closed

[BUG/ISSUE] Wrong precision used for MO2 + HO2 reaction in fullchem.eqn #951

yantosca opened this issue Oct 12, 2021 · 4 comments · Fixed by #952
Assignees
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Configuration Files Related to GEOS-Chem configuration files
Milestone

Comments

@yantosca
Copy link
Contributor

In fullchem.eqn, this reaction:

MO2 + HO2 = MP + O2 :                        GCARR_abc(4.10E-13, 0.0E+00, 750.0);

should use double-precision exponents:

MO2 + HO2 = MP + O2 :                        GCARR_abc(4.10d-13, 0.0d0, 750.0d0);

to avoid type errors.

NOTE: This was not flagged by any integration tests using Gfortran 10.2, but @jimmielin reported this issue in a development branch that he was working on.

@yantosca yantosca added category: Bug Something isn't working topic: Configuration Files Related to GEOS-Chem configuration files labels Oct 12, 2021
@jimmielin
Copy link
Contributor

These also seem to have single-precision exponents:

B3O2 + NO = NO2 + HO2 + ACET :               GC_RO2NO_B2_aca(2.70E-12, 360.0d0, 3.0d0);                                        {2019/05/10; Fisher2018; JAF}
B3O2 + NO = IPRNO3 :                         GC_RO2NO_A2_aca(2.70E-12, 360.0d0, 3.0d0);                                        {2019/05/10; Fisher2018; JAF}

Not sure if they also affect compile, but I fixed all of them to pass gfortran compile with standalone KPP.

@yantosca yantosca added this to the 13.4.0 milestone Oct 12, 2021
@yantosca
Copy link
Contributor Author

This can be added to 13.4.0 since it will change benchmark results (even if slightly).

@stale
Copy link

stale bot commented Nov 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the stale No recent activity on this issue label Nov 11, 2021
@yantosca yantosca added the never stale Never label this issue as stale label Nov 15, 2021
@stale stale bot removed the stale No recent activity on this issue label Nov 15, 2021
@yantosca
Copy link
Contributor Author

PR #952 has now been merged into dev. We can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Configuration Files Related to GEOS-Chem configuration files
Projects
None yet
2 participants