Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase string length for netCDF variable name #248

Merged

Conversation

msulprizio
Copy link
Contributor

Name and Institution (Required)

Name: Melissa Sulprizio
Institution: Harvard / GCST

Describe the update

The GHGI v2 inventory in CH4 and carbon simulations within GEOS-Chem introduced netCDF varible names that exceeded the current defined string length (50 characters). This value has been increased to 100 to avoid errors.

Expected changes

This is a zero difference update.

The GHGI v2 inventory in CH4 and carbon simulations within GEOS-Chem
introduced netCDF varible names that exceeded the current defined string
length (50 characters). This value has been increased to 100 to avoid
errors.

Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
@msulprizio msulprizio added the category: Bug Fix Fixes a bug that was previously reported label Nov 17, 2023
@msulprizio msulprizio added this to the 3.7.2 milestone Nov 17, 2023
@msulprizio msulprizio self-assigned this Nov 17, 2023
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple PR that just changes the line length of a string variable. Good to merge.

@yantosca yantosca added topic: Input Data Related to input/emissions data, or disk read/write operations no-diff-to-benchmark This update will have no impact on benchmark simulations labels Nov 20, 2023
@yantosca
Copy link
Contributor

All GEOS-Chem Classic integration tests (except TOMAS) passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #f5b5694 Merge branch 'docs/dev' into dev/14.2.2
GEOS-Chem #382f11dca Merge PR #2040 (Lower GCHP timestep threshold if > C180)
HEMCO     #6ab11ea Merge PR #245 (Rename HEMCO_Config.rc.sample to HEMCO_Config.rc)

Using 24 OpenMP threads
Number of execution tests: 27

Submitted as SLURM job: 10285010
==============================================================================

Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 25
Execution tests failed: 2                # <==== TOMAS15 and TOMAS40
Execution tests not yet completed: 0

All GEOS-Chem Classic integration tests were zero-diff w/r/t 14.2.2, except TOMAS (failed), APM (parallelization issues) and RRTMG (parallelization issue in diagnostic output).

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

gchp      #074494e GEOS-Chem submodule update: Merge PR #2009 fixing links to RTD
GEOS-Chem #382f11dca Merge PR #2040 (Lower GCHP timestep threshold if > C180)
HEMCO     #6ab11ea Merge PR #245 (Rename HEMCO_Config.rc.sample to HEMCO_Config.rc)

Number of execution tests: 5

Submitted as SLURM job: 10285450
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

All GCHP integration tests were also zero-diff w/r/t 14.2.2.

@yantosca yantosca merged commit 697a28d into dev/no-diff-to-benchmark Nov 20, 2023
1 check passed
@yantosca yantosca deleted the bugfix/increase-netcdf-var-string-length branch November 20, 2023 21:48
yantosca added a commit that referenced this pull request Dec 1, 2023
This is the official release of HEMCO 3.7.2.  Updates include:

- Add utility scripts to change version numbers before release (PR #242)
- Rename HEMCO Config.rc.sample to HEMCO_Config.rc for standalone (PR #245)
- Increase string length for netCDF variable name (PR #248)
- Turn off emission extensions when EMISSIONS logical is false (PR #250)

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a bug that was previously reported no-diff-to-benchmark This update will have no impact on benchmark simulations topic: Input Data Related to input/emissions data, or disk read/write operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants