Turn off emission extensions when EMISSIONS logical is set to false #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EMISSIONS logical switch in HEMCO_Config.rc currently only turns off base emissions and not the emission extensions. The emission extension data are bracketed by the logical so those data are not read in. However, because the extensions themselves are still on, they get called in HEMCO and result in the model crashing because the input data can't be found. This is now fixed by adding a check in subroutine ExtSwitch2Buffer (in hco_config_mod.F90) to see if EMISSIONS is set and using that to define a local logical DoEmis. In that same routine, if DoEmis is false then all emission extensions will be defined with Enabled = .FALSE. to avoid calling them during the run stage of HEMCO. Addresses #249. Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
msulprizio
added
topic: Configuration Files
yantosca
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
This all looks good to merge. I'll start working on getting this into the no-diff-to-benchmark branch. Thanks @msulprizio!
|
All GEOS-Chem Classic integration tests (except for TOMAS) passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #026388b HEMCO submod update: Include script to change HEMCO version numbers
GEOS-Chem #78c1b7dc3 Merge PR #2042 (Fix HEMCO_Config.rc for CH4 and carbon simulations)
HEMCO #7e36ad3 Merge PR #250 (Turn off emission extensions when EMISSIONS is off )
Using 24 OpenMP threads
Number of execution tests: 27
Submitted as SLURM job: 11020335
==============================================================================
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 25
Execution tests failed: 2
Execution tests not yet completed: 0Also all integration tests were identical to the integration tests for PR #2042 except for:
|
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #fe78a2b HEMCO submod update: Include script to change HEMCO version numbers
GEOS-Chem #78c1b7dc3 Merge PR #2042 (Fix HEMCO_Config.rc for CH4 and carbon simulations)
HEMCO #7e36ad3 Merge PR #250 (Turn off emission extensions when EMISSIONS is off )
Number of execution tests: 5
Submitted as SLURM job: 11020520
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All integration tests were also zero-diff w/r/t the integration test for PR #2042. |
This was referenced Nov 28, 2023
yantosca
added a commit
that referenced
this pull request
Dec 1, 2023
This is the official release of HEMCO 3.7.2. Updates include: - Add utility scripts to change version numbers before release (PR #242) - Rename HEMCO Config.rc.sample to HEMCO_Config.rc for standalone (PR #245) - Increase string length for netCDF variable name (PR #248) - Turn off emission extensions when EMISSIONS logical is false (PR #250) Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
|
Related issue: geoschem/geos-chem#1420 |
|
I verified this works in GCHP fullchem and transport tracers simulations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard / GCST
Describe the update
The
EMISSIONSlogical switch in HEMCO_Config.rc currently only turns off base emissions and not the emission extensions. The emission extension data are bracketed by the logical so those data are not read in. However, because the extensions themselves are still on, they get called in HEMCO and result in the model crashing because the input data can't be found.This is now fixed by adding a check in subroutine
ExtSwitch2Buffer(inhco_config_mod.F90) to see ifEMISSIONSis set and using that to define a local logicalDoEmis. In that same routine, ifDoEmisis false then all emission extensions will be defined withEnabled = .FALSE.to avoid calling them during the run stage of HEMCO.Addresses #249.
Expected changes
This fix will result in zero differences in out-of-the-box simulations because
EMISSIONSis set to true by default in all simulations.Related Github Issue(s)