-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example in the README does not work #15
Comments
The from async_dns import get_nameservers
resolver = ProxyResolver(proxies=get_nameservers()) |
Thanks @gera2ld, this seems to have fixed the issue. It's strange as I thought that I had used I'll probably do some other tests in a docker container or virtual environment on my machine so I don't have this issue again. A quick question. Are there any plans to return errors when a domain name is not found, or the server fails, or there is a timeout etc.? At the moment |
Not yet but perhaps there should be. This project was designed to simply provide a DNS service at the beginning and the APIs are not well designed. |
I see what you are saying. However, the design of the API is not actually as as bad as you say. You've done a good job making the API very concise. I've had a lot of experience designing APIs in the past and good APIs are hard to design. The main thing missing is documentation of the Possibly the responses could be split out into their own classes. But I think more comprehensive documentation and clear naming would probably make this less essential. It took me a bit of time to work out the responses depending on the name servers I was using ( |
Hi,
This library seems to have some very good functionality and I am looking into incorporating it into a project of mine. However, I'm struggling to get the example that you have in the
README
to even work:I get a value of
None
returned when I paste the code into the following online REPL: https://repl.it/repls/CoordinatedLameCoinsYou can see the versions of
python
andpypi
libraries being used in thepyproject.toml
. Even when I edit the file to force the use of the latest version (1.0.9
) I get the same result.Also, even if I change the domain name to
google.com
,facebook.com
etc. the sameNone
result is returned.Am I missing something here?
The text was updated successfully, but these errors were encountered: