Ratio of ps2 longbox thumbnails looks wrong? #385
Comments
|
The original file has a correct aspect ratio: http://rpdb.gerbilsoft.com/ps2/cover/SLES/SLES-55103.jpg This is definitely a Windows rendering issue. I'll need to figure out why it's being rendered incorrectly. |
|
This is also affecting Wii U boxart, and probably others. (Tested on Windows 7.) It should be creating a squared thumbnail, but obviously something is wrong... |
|
Watch, it's going to be something stupid like Windows changing how thumbnails work.... again |
|
It seems the "squaring" function that's needed for icons to work properly somehow caused long boxes to get squished. I'm pretty sure it worked before... Disabled squaring on everything except icons and it seems to work now. Tested on Windows 7 with IThumbnailProvider. Will test IExtractImage later to ensure it isn't broken, but IExtractImage is generally only used on Windows XP and other older software. |
|
As soon as the build pops out of appveyor I will test on my end to make sure everything is good |
|
@GerbilSoft Aspect Ratio is still wrong |
|
Did you clear the thumbnail cache? (rp-config has a convenient button to do this.) |
|
Yep, unregistered the old dll, used rp-config to clean both rp's cache and the system cache, checked some isos to make sure that they weren't showing anything other than the default icon, and then registered the new dll |
|
I'll need to test it on my Win10 VM then. (It seems to have fixed it for Win7, at least...) |
|
I'm not able to reproduce this on Windows 10 v1809. What version of Windows 10 (or 11) are you using? |
|
|
|
Will set up a Windows 11 22H2 VM tomorrow then. This will probably be the last bugfix I'll look at before releasing v2.2.1. |
|
I have good news. Turns out that Windows and its ability to be dumb never ends, and I was actually still running the old build even though it said that it had unregistered it. New DLL generates box arts correctly! |
|
Unless you can think of anything else you want me to test or last minute fixes for something, I think everything is good on my end now. |
|
Something I have noticed is that initially it still generates as the squished thumbnail and then seemingly makes a second pass and fixes the aspect ratio. |
|
Reopening, just in case you want to look into that. If not, feel free to close, it seems like the correct one gets saved to the cache in the end so it just ends up being a visual quirk |
|
That's the icon, which appears to be squished. (If you view file properties, you'll see the squished icon.) I'm not sure why it's getting squished, since the squaring is supposed to add columns but not change the aspect ratio... |
|
It seems removing squaring for icons fixes it. I know I had problems with non-square icons before, but that might have been on Windows XP. I'll change it to only enable squared icons on Windows XP and earlier. (Not sure about IExtractImage; will need to test that later.) |
Thumbnails for images that were taller than they were wide appeared squished with squaring enabled, even though the generated image is correct. Not sure why this is happening... Windows XP had issues with non-square icons, but Windows 7 seems to be handling them without any problems. See #385: Ratio of ps2 longbox thumbnails looks wrong?
|
Icon squaring is now disabled on Vista and later. My WinXP VM isn't working properly due to some weird interaction with VirtualBox and SMAP, and reporting a bug to VirtualBox requires registering an Oracle account. I could probably work around this by disabling SMAP, but I'd rather not do that... |
|
I truly feel for you, I don't think anybody willingly wants to deal with oracle lol |
|
Closing since this should be fixed in Windows Vista and later. Will need to test XP again sometime... |
I would look myself to see what they are getting displayed as, but to my eye, the ps2 thumbnails look to have the wrong aspect ratio. It looks like they are taller and not as wide as they should be
The text was updated successfully, but these errors were encountered: