Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gamecube Property sheet is blank #389

Closed
Masamune3210 opened this issue Jul 8, 2023 · 2 comments
Closed

Gamecube Property sheet is blank #389

Masamune3210 opened this issue Jul 8, 2023 · 2 comments
Assignees
@GerbilSoft
Labels
bug FIXED
Milestone
2.2.1

Comments

@Masamune3210
Copy link

Getting a weird issue with the latest release with rvz's. No thumbnail is being shown and the property sheet is completely blank save for the header stating that its a Nintendo Gamecube Disk Image
image
@Masamune3210
Copy link
Author

Masamune3210 commented Jul 8, 2023 •
edited

Same thing happens with Wii, maybe a issue with the rvz parser?
image

@GerbilSoft
Copy link
Owner 

dd414bc544cddb65f21a49a1c071d0fad17adcc7 is the first bad commit
commit dd414bc544cddb65f21a49a1c071d0fad17adcc7
Author: David Korth <gerbilsoft@gerbilsoft.com>
Date:   Sun Feb 19 00:57:53 2023 -0500

    [libromdata] GameCube: Handle standalone Wii update partitions containing Incrementing Values.
    
    Reported by @johnsanc314.

@GerbilSoft GerbilSoft self-assigned this Jul 8, 2023
@GerbilSoft GerbilSoft added the bug label Jul 8, 2023
@GerbilSoft GerbilSoft added this to the 2.2.1 milestone Jul 8, 2023
GerbilSoft added a commit that referenced this issue Jul 9, 2023
@GerbilSoft
[libromdata/tests] RomHeaderTest: Add a few WIA/RVZ headers.
d999aae 
More than once, the WIA/RVZ parser has broken, resulting in a blank
properties tab. The last one I missed and ended up in v2.2, and an
issue was filed. (#389: Gamecube Property sheet is blank)

Adding this to RomHeaderTest should prevent this from happening by
causing AppVeyor to fail if it breaks again.

Currently, two disc images are included, in both WIA and RVZ formats,
with just 256 bytes from the header, and 4096 blank bytes to allow it
to pass tests in the GameCube constructor:

- rubysap-timerfix-1219-10-eng (GCN; "berry program update")
- swupdate_ALL_us (Wii; RVT IOS updater)
GerbilSoft added a commit that referenced this issue Jul 9, 2023
@GerbilSoft
[libromdata/tests] RomHeaderTest: Add a few WIA/RVZ headers.
d5ac17c 
More than once, the WIA/RVZ parser has broken, resulting in a blank
properties tab. The last one I missed and ended up in v2.2, and an
issue was filed. (#389: Gamecube Property sheet is blank)

Adding this to RomHeaderTest should prevent this from happening by
causing AppVeyor to fail if it breaks again.

Currently, two disc images are included, in both WIA and RVZ formats,
with just 256 bytes from the header, and 4096 blank bytes to allow it
to pass tests in the GameCube constructor:

- rubysap-timerfix-1219-10-eng (GCN; "berry program update")
- swupdate_ALL_us (Wii; RVT IOS updater)

Code coverage changes:

Before:
  lines......: 22.3% (11572 of 52001 lines)
  functions..: 20.7% (734 of 3542 functions)

After:
  lines......: 22.4% (11673 of 52001 lines)
  functions..: 20.9% (740 of 3542 functions)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GerbilSoft GerbilSoft

Labels
bug FIXED
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
2 participants
@Masamune3210 @GerbilSoft