Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drill.c -- Pay down accrued technical debt #221

Open
henrygab opened this issue Sep 5, 2023 · 0 comments · May be fixed by #226
Open

drill.c -- Pay down accrued technical debt #221

henrygab opened this issue Sep 5, 2023 · 0 comments · May be fixed by #226

Comments

@henrygab
Copy link
Contributor

henrygab commented Sep 5, 2023

  • See SEI CERT C Coding Standard

  • Remove unused parameters from internal functions

    • drill_add_drill_hole()
    • new_state()

  • Use consistent order for similar function parameters

    • Reduces mental load
    • Avoids stack reshuffling
    • Easier debugging (stack in same order...)

  • Use descriptive variable names

  • Reduce cyclomatic complexity of large functions

These are all at least partially addressed by #210
@henrygab henrygab mentioned this issue Sep 5, 2023
Closed
@henrygab henrygab linked a pull request Oct 18, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix multiple issues henrygab/gerbv
Fix multiple issues henrygab/gerbv
1 participant
@henrygab