Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated csbluegem to work for M9 Bayonets #515

Merged
merged 6 commits into from Feb 10, 2024

Conversation

dnsmits
Copy link
Contributor

@dnsmits dnsmits commented Feb 9, 2024

currently, blue percents are working properly, but grabbing the percentages for "Bayonet" when knife is an "M9 Bayonet". Fixed this issue. DID NOT TEST, just made logical changes. Please review.

dnsmits and others added 4 commits February 8, 2024 20:47
currently, blue percents are working properly, but grabbing the percentages for "Bayonet" when knife is an "M9 Bayonet". Fixed this issue. DID NOT TEST, just made logical changes. Please review.
@gergelyszabo94
Copy link
Owner

Hello, I confirmed that the extension currently takes the wrong (bayo) data.

I fixed a syntax issue and confirmed that the original problem was fixed.

Can you explain this bit please?
// name === knifeName condition set in the event chKnifeNames key changes

@dnsmits
Copy link
Contributor Author

dnsmits commented Feb 10, 2024

as is, that conditional will always be false. I included that condition in the event the chKnifeNames array is changed. I didn't particularly agree with how it was implemented (as logic to convert white space to underscores for each name) seemed more natural. Thus, I included name === knifeName in the event chKnifeNames took the form of:

const chKnifeNames = [
['★ Bayonet | Case Hardened', 'Bayonet'],
];

Allowing you to compare the item's name directly to the key

@gergelyszabo94 gergelyszabo94 merged commit d30ac60 into gergelyszabo94:master Feb 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants