-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PID function #13
Comments
Thanks for your contribution and greetings from the train...:) Here is my take:
|
OK, I agree:-) |
Haven't seen the picture on my cell, yes - this is the one. Absolute is a bit more intuitive, incremental could be an alternate option... |
|
pid1() is based on @mgulan s difference equation method. |
Ok, I see! In that case it needs to be properly tetsed and thought out how it will be included in the library. |
I've been trying to commit my code for PID for at least two hours, but I cannot seem to figure out what's wrong. Do I need a permission to do that or I am still doing something wrong? |
@kulho You haven't accepted the invite yet. Sent a mail about it. |
@Gabor7697 deleted your new PID branch, because I merged to master anyways. The "old" PID is there only until tomorrow, until we discuss how to continue. Also I want to review @kulho changes and show how it is not a good idea to to rewrite someone's code;) |
-~~~leave pid alone and/or combine it with @rkoplinger version~~~ |
Just a quick idea: pick a way to input tuning to PID and stick with it. But then, you could do a function that translates between the two... |
There has been lots of improvement from the original PID function and the redesign helped a lot as well, see #46 |
Here is the version of the digital PID controller that you could implement, see attachment.
If you needed help/ideas with the code, let me know.
Think of what will be the inputs/outputs of the function, whether it shall internally contain anti wind-up, saturation, pre-filtering, etc.
The text was updated successfully, but these errors were encountered: