Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Wallaby Driver #73

Open
arnodirlam opened this issue Apr 30, 2024 · 1 comment · May be fixed by #74
Open

Suggestion: Wallaby Driver #73

arnodirlam opened this issue Apr 30, 2024 · 1 comment · May be fixed by #74

Comments

@arnodirlam
Copy link

arnodirlam commented Apr 30, 2024

Would it be possible to add a Driver implementation for Wallaby?

I envision that this could be used for UI tests that involve JavaScript of any sorts, so we could test JavaScript from PhoenixTest using all the same primitives.

Once we use JavaScript in a page, we could add a test tag (e.g. @tag :js). For tests without the tag, it'd use the LiveView or static driver, using much less time and resources for running the test.

In that world, we could write truly user-centric tests without having to care about implementation details such as where JavaScript is used, and easily switch browser-based testing on and off.

Thanks a lot for the great library and its approach!

@germsvel
Copy link
Owner

😄 you read my mind. Adding Wallaby as an option (probably through a js tag) is something I'd love to do. But it's probably a bigger lift, and I don't know when I'll have time to dig into it. But I think it would be very cool to have that work.

@ftes ftes linked a pull request May 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants