Homematic #3
Homematic #3
Conversation
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
…ixes openhab#1437) (openhab#2221) Signed-off-by: Alexander Falkenstern <alexander.falkenstern@gmail.com> (github: falkena)
# Conflicts: # addons/binding/org.openhab.binding.homematic/src/main/java/org/openhab/binding/homematic/handler/HomematicThingHandler.java
…s on slower computers Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
# Conflicts: # addons/binding/org.openhab.binding.homematic/src/main/java/org/openhab/binding/homematic/handler/HomematicBridgeHandler.java # addons/binding/org.openhab.binding.homematic/src/main/java/org/openhab/binding/homematic/handler/HomematicThingHandler.java
|
Thank you for this PR, can you please rebase your branch, because there are so many older commits. |
|
It's better now? Further rebasing produces a lot of conflicts. |
| updateStatus(ThingStatus.ONLINE); | ||
|
|
||
| try { | ||
| isInitializedLock.lock(); |
There was a problem hiding this comment.
I don't know for what the ReentrantLock is good for. I do not think that's the right approach, because all bindings would have to add such a lock.
Have you seen, that the BrideHandler.initialize() method is called twice?
There was a problem hiding this comment.
Well, the problem comes, since "onConnectionResumed" and "initialize" sets state of bridge to ONLINE. If "onConnectionResumed" will be called first, thing goes online and framework will not call "initialize", since already ONLINE. Reenetrant lock is "good old scholl" mutex, someting like syncronized, only for any peace of code. Not objects only. No i have not seen, that "initialize" was called twice, on my PC it was called once only. Do we have next race condition here? May be it's better solution to use getThing().getStatusInfo() instead of using "isInitialized" member.
There was a problem hiding this comment.
Nearly the same problem is in HomematicThingHandler: take a look into "updateDatapointState" and "initialize" methods calls. They will be called from different threads also, like "initialize" and "onConnectionResumed" in HomematicBridgeHandler. What ever the implementation is, we should wait with further threads processing until things are initialized.
| if (hmThing != null) { | ||
| HomematicThingHandler thingHandler = (HomematicThingHandler) hmThing.getHandler(); | ||
| thingHandler.updateDatapointState(dp); | ||
| final HmChannel hmChannel = dp.getChannel(); |
There was a problem hiding this comment.
It's better to do this in the AbstractHomematicGateway.eventReceived(). Good hint!
|
Something is wrong with this PR, it removes some changes i did recently. |
|
@falkena But i have implemented your changes and also found another solution without the lock. So thank you for your help and hints! |
|
@gerrieg Sure. It helped to solve the Problem. So, i would say: "Mission complete" :-) |
Hi,
it seems, that i got the error we speak about:
https://community.openhab.org/t/homematic-binding-channel-not-found-for-datapoint-errors-for-definitely-existing-channels/26209/19
Please, take a look. May be it's ok for you.