New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean code in install #21

Open

luanluciano93 opened this issue Aug 28, 2015 · 1 comment

Labels

bug

luanluciano93 commented Aug 28, 2015

Hello Gesior could simplify this code:
https://github.com/gesior/Gesior2012/blob/TFS-1.0/install.php#L18-L52

that is why:
include_once('./system/load.init.php');

https://github.com/gesior/Gesior2012/blob/TFS-1.0/install.php#L145-L179
that is why:
include_once('./system/load.database.php');

among other things ..

Owner

gesior commented Sep 8, 2015

If someone got a minute:

change it
test if installer still works
make pull request

Refactoring in Gesior is around.. zero, so these lines is not a big problem.

gesior added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment