Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

Alternatives to row_mins_c #37

Open
kbenoit opened this issue Nov 17, 2023 · 2 comments
Open

Alternatives to row_mins_c #37

kbenoit opened this issue Nov 17, 2023 · 2 comments

Comments

@kbenoit
Copy link

kbenoit commented Nov 17, 2023

https://stackoverflow.com/a/69195111/4158274

matrixStats::rowMins()

and what about ties?

@schochastics
Copy link
Member

row_mins_c is giving the same results as matrixStats::rowMins() but is slightly faster because it is optimized for our case. One could surely opt for matrixStats::rowMins() but that would add a dependency that is not necessary.

Concerning ties: We only need the minimum value in a row, not its index (but @chainsawriot sould confirm that)

@chainsawriot
Copy link
Contributor

chainsawriot commented Nov 18, 2023

@schochastics Regarding ties: Yes, we only need the minimum value.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants