Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save token to environment #18

Closed
schochastics opened this issue Nov 7, 2022 · 3 comments
Closed

save token to environment #18

schochastics opened this issue Nov 7, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@schochastics
Copy link
Member

See discussion #15 (comment)

@schochastics schochastics added the planned later feature that might be added later label Nov 7, 2022
@JBGruber
Copy link
Contributor

JBGruber commented Nov 8, 2022

Not sure if it makes more sense to save the token or the token location as the env variable. The token consists of 3 relevant parts: bearer, instance and type. These could go into one env variable, but we would need to also parse it then. Or they go into 3 variables, which seems a bit clumsy to me.

I would say the file and path in the variable approach is cleaner. But maybe we need the whole token for testing (#19)?

@chainsawriot
Copy link
Collaborator

@JBGruber Not in a straight sense. The envvar RTOOT_DEFAULT_TOKEN is for filtering out the sensitive information (i.e. the token) when creating vcr cassettes. It won't need for testing.

@schochastics schochastics added enhancement New feature or request and removed planned later feature that might be added later labels Nov 9, 2022
@chainsawriot
Copy link
Collaborator

GOTO #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants