Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pull in rules from remote repos #104

Closed
armanrahman22 opened this issue Jul 19, 2021 · 2 comments
Closed

Ability to pull in rules from remote repos #104

armanrahman22 opened this issue Jul 19, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@armanrahman22
Copy link
Contributor

Link to original issue on forked repo: inclusive-dev-tools#1

Problem Statement

Right now the code looks locally for the rules file, but we want to be able to source it from any public URL to allow for reuse of external rule sets

Acceptance Criteria

  • Ability to run the linter on a publicly accessible ruleset file by pointing to it in the cli arguments. e.g. woke -u https://raw.githubusercontent.com/get-woke/woke/main/example.yaml
@armanrahman22 armanrahman22 added the enhancement New feature or request label Jul 19, 2021
@caitlinelfring
Copy link
Member

This is a feature I've very much been wanting. I have some thoughts around it, but generally I'd like to be able to support:

  • Defining N ruleset urls as cli arguments (like you suggested, but woke doesn't support defining rulesets outside of the config yet)
  • Define a remote config woke -c https:///...
  • Extend the ruleset in your config (see Community-driven rule list #67 (comment))
  • Stretch goal: support advanced download protocols, like ssh, s3 (for private repos/buckets for example) -- Came across https://github.com/hashicorp/go-getter which is promising but it doesn't seem to work very well with single files

@caitlinelfring
Copy link
Member

🎉 Released in v0.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants