Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject channel offer if processing it failed #2132

Closed
holzeis opened this issue Mar 1, 2024 · 1 comment · Fixed by #2157
Closed

Reject channel offer if processing it failed #2132

holzeis opened this issue Mar 1, 2024 · 1 comment · Fixed by #2157
Assignees
@holzeis

Comments

@holzeis
Copy link
Contributor

holzeis commented Mar 1, 2024

At the moment we only reject a channel offer if accepting it failed. With #2131 we had a scenario where the processing of the offer was already failing, leaving the app and the coordinator in a stuck state.

It is possible though to manually clean up the state.
@bonomat
Copy link
Contributor

bonomat commented Mar 5, 2024

If the app could not process the offer it should reject the offer. Otherwise the coordinator and the app are in a stuck state.

This applies for renew offer, settle offer and new channel offer.

@holzeis holzeis self-assigned this Mar 5, 2024
@holzeis holzeis linked a pull request Mar 5, 2024 that will close this issue
chore(channel offer): Reject a dlc channel offer if the processing fails #2157
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holzeis holzeis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(channel offer): Reject a dlc channel offer if the processing fails get10101/10101
2 participants
@bonomat @holzeis